Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[automattic.com] New ruleset - #3983

Merged
J0WI merged 1 commit into
EFForg:masterfrom
youdly:automattic
Apr 14, 2016
Merged

J0WI merged 1 commit into
EFForg:masterfrom
youdly:automattic

Conversation

@youdly

@youdly youdly commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@J0WI

J0WI commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

This domain was added in 73b763f and removed in 143128b

How do we handle this?
@fuglede @semenko @jsha

@semenko

semenko commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

We don't have a great way of handling this :(

We might want to rethink our mechanism for storing rules, especially as TLS adoption expands. Our current "throw a bunch of .xml files in a folder" strategy could definitely be improved.

@fuglede

fuglede commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

To make sure I understand: what is the issue exactly? That one is not automatically exposed to the information about the ruleset having existed previously, or something more concrete than that?

@semenko

semenko commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

I think that's correct. Pondering some other rule storage options that might address this.

@fuglede

fuglede commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

I don't necessarily think that that's a big issue, but one simple way out of it -- if we were better at keeping disabled rulesets out of memory at least -- would be to only ever default_off ruleset files instead of deleting them.

@semenko

semenko commented Jan 25, 2016

Copy link
Copy Markdown
Contributor

Agreed -- though I do think we should ponder reorganizing our ruleset chaos. I'll make an issue at some point...

@J0WI

J0WI commented Jan 26, 2016

Copy link
Copy Markdown
Contributor

My question was about how we handle such scenarios:
Reverting the remove or just merging the new one?

This was referenced Apr 9, 2016
@J0WI
J0WI merged commit ba2fa82 into EFForg:master Apr 14, 2016
@youdly
youdly deleted the automattic branch May 3, 2019 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants